Page MenuHomePhabricator

[depends] boost: update to 1.70
ClosedPublic

Authored by Fabien on Mar 31 2020, 18:08.

Details

Summary

Backport of core PR15461.

This PR is known to cause 2 issues:

  • The build (native) on ARM might be broken:

https://github.com/bitcoin/bitcoin/issues/17010

  • The error messages are not helpful:

https://github.com/bitcoin/bitcoin/issues/16803

None of these issues are critical.

I kept (adapted) the patch to work around the first issue. It doesn't
provide a very solid guarantee but it can't hurt.

The second issue will be fixed in a future backport.

Note that due to boost cmake update, it is now required to set
Boost_USE_STATIC_RUNTIME to ON.

Test Plan
make
make check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 31 2020, 18:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2020, 18:08
teamcity edited the summary of this revision. (Show Details)Mar 31 2020, 18:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Mar 31 2020, 20:51
This revision is now accepted and ready to land.Mar 31 2020, 20:51
This revision was automatically updated to reflect the committed changes.