Page MenuHomePhabricator
Differential D5664

depends: add ability to skip building qrencode
ClosedPublic
Actions

Authored by Fabien on Apr 3 2020, 08:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING860c08740106: depends: add ability to skip building qrencode
rABC860c08740106: depends: add ability to skip building qrencode
Summary
Similar to other depends packages, add the ability to skip building
qrencode by passing NO_QR=1.

Backport of core PR17658.

Test Plan
make build-osx NO_QR=1

Check the qrencode lib is not built.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 3 2020, 08:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2020, 08:18
teamcity edited the summary of this revision. (Show Details)Apr 3 2020, 08:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 3 2020, 09:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 3 2020, 10:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10115: Diff 17428.Apr 3 2020, 10:04
deadalnix accepted this revision.Apr 3 2020, 13:19
This revision is now accepted and ready to land.Apr 3 2020, 13:19
Closed by commit rABC860c08740106: depends: add ability to skip building qrencode (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 3 2020, 15:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC860c08740106: depends: add ability to skip building qrencode.
Fabien added a commit: rSTAGING860c08740106: depends: add ability to skip building qrencode.Apr 7 2020, 23:37

Revision Contents
Changeset List

PathSize
depends/
7 lines
1 line
4 lines
packages/
4 lines

Diff 17439

View Options

depends/Makefile

Loading...
View Options

depends/README.md

Loading...
View Options

depends/config.site.in

Loading...
View Options

depends/packages/packages.mk

Loading...