Page MenuHomePhabricator
Differential D5688

[backport] RPCAuth Detection in Logs
ClosedPublic
Actions

Authored by majcosta on Apr 9 2020, 12:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf771ebd4b380: [backport] RPCAuth Detection in Logs
rABCf771ebd4b380: [backport] RPCAuth Detection in Logs
Summary

dae0d13bbb710346a8f4c8ecdf96937283e470df RPCAuth Detection in Logs (Linrono)

Pull request description:

This adds a log entry for when RPCAuth is detected.
This keeps everything working as it currently is. I suppose it could be added as a nested if to also stop the creation of the cookie file if this would be wanted.

This is a backport of Core PR13118

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 9 2020, 12:30
Owners added a reviewer: Restricted Owners Package.Apr 9 2020, 12:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2020, 12:30
teamcity edited the summary of this revision. (Show Details)Apr 9 2020, 12:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 9 2020, 12:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 9 2020, 12:39
teamcity added a comment.Apr 9 2020, 12:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10152: Diff 18705.Apr 9 2020, 12:42
deadalnix accepted this revision.Apr 9 2020, 16:48
This revision is now accepted and ready to land.Apr 9 2020, 16:48
Closed by commit rABCf771ebd4b380: [backport] RPCAuth Detection in Logs (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyApr 9 2020, 17:24
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf771ebd4b380: [backport] RPCAuth Detection in Logs.
majcosta added a commit: rSTAGINGf771ebd4b380: [backport] RPCAuth Detection in Logs.May 5 2020, 18:54

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 18708

View Options

src/httprpc.cpp

Loading...