Page MenuHomePhabricator
Differential D5706

Factor BroadcastTransaction out of sendrawtransaction
ClosedPublic
Actions

Authored by Fabien on Apr 13 2020, 14:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6ed34f9cc7cc: Factor BroadcastTransaction out of sendrawtransaction
rABC6ed34f9cc7cc: Factor BroadcastTransaction out of sendrawtransaction
Summary
Factor out a new BroadcastTransaction function, performing the core work
of the sendrawtransaction rpc, so that it can be used from the GUI code.
Move it from src/rpc/ to src/node/.

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/81cd9588484cb4f4050ea4e239da0681111795db

Test Plan
ninja all check
./test/functional/test_runner.py rpc_rawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 13 2020, 14:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 14:16
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 14:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 14:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added inline comments.Apr 13 2020, 14:19
src/rpc/rawtransaction.cpp
7 ↗(On Diff #18759)

Used to be pulled by net.h, needed

28 ↗(On Diff #18759)

Still required.

teamcity added a comment.Apr 13 2020, 14:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10187: Diff 18759.Apr 13 2020, 14:28
deadalnix accepted this revision.Apr 14 2020, 12:55
This revision is now accepted and ready to land.Apr 14 2020, 12:55
Closed by commit rABC6ed34f9cc7cc: Factor BroadcastTransaction out of sendrawtransaction (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 15 2020, 10:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6ed34f9cc7cc: Factor BroadcastTransaction out of sendrawtransaction.
Fabien added a commit: rSTAGING6ed34f9cc7cc: Factor BroadcastTransaction out of sendrawtransaction.May 5 2020, 18:57

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
node/
17 lines
89 lines
rpc/
74 lines

Diff 18820

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/node/transaction.h

Loading...
View Options

src/node/transaction.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...