Page MenuHomePhabricator
Differential D5810

Add RPC Whitelist Feature from #12248
ClosedPublic
Actions

Authored by deadalnix on Apr 22 2020, 20:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING15a5df03b0d2: Add RPC Whitelist Feature from #12248
rABC15a5df03b0d2: Add RPC Whitelist Feature from #12248
Summary
  • test: Add test for rpc_whitelist

This is a backport of Core PR12763

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 22 2020, 20:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2020, 20:47
teamcity edited the summary of this revision. (Show Details)Apr 22 2020, 20:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 22 2020, 20:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 22 2020, 21:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10356: Diff 19034.Apr 22 2020, 21:10
Fabien accepted this revision.Apr 23 2020, 08:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/httprpc.cpp
343 ↗(On Diff #19034)

Nit: it is not clear the comment relates to the else case due to indentation. Can you fix this ?

358 ↗(On Diff #19034)

Dito

This revision is now accepted and ready to land.Apr 23 2020, 08:40
Closed by commit rABC15a5df03b0d2: Add RPC Whitelist Feature from #12248 (authored by Jeremy Rubin <j@rubin.io>, committed by deadalnix). · Explain WhyApr 23 2020, 21:45
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC15a5df03b0d2: Add RPC Whitelist Feature from #12248.
deadalnix added a commit: rSTAGING15a5df03b0d2: Add RPC Whitelist Feature from #12248.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
src/
75 lines
17 lines
test/
functional/
176 lines

Diff 19070

View Options

src/httprpc.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

test/functional/rpc_whitelist.py

Loading...