Page MenuHomePhabricator
Differential D5838

Pass rpc/net RPC Results and Examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 25 2020, 01:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan
rABC8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched net.diff

Verify net.diff does not exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 25 2020, 01:06
Owners added a reviewer: Restricted Owners Package.Apr 25 2020, 01:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 25 2020, 01:06
nakihito planned changes to this revision.Apr 25 2020, 01:06
teamcity edited the summary of this revision. (Show Details)Apr 25 2020, 01:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Apr 25 2020, 01:07
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 25 2020, 01:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 25 2020, 01:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10406: Diff 19123.Apr 25 2020, 01:35
deadalnix accepted this revision.Apr 25 2020, 02:33
This revision is now accepted and ready to land.Apr 25 2020, 02:33
Closed by commit rABC8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 27 2020, 17:43
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan.
nakihito added a commit: rSTAGING8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan.May 5 2020, 19:09

Revision Contents
Changeset List

PathSize
src/
rpc/
712 lines

Diff 19167

View Options

src/rpc/net.cpp

Loading...