Differential D5872

[CMAKE] Fix the build with ZMQ disabled
ClosedPublic
Actions

Authored by Fabien on Apr 28 2020, 12:23.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled
rABCee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled

Summary

ZMQ is conditionally linked to the server library, so executables
linking against server will get ZMQ as needed.

The wallet library unconditionally links against zmq since D5840, which
can cause the build to fail if ZMQ is disabled and the linker cannot
solve the -lzmq flag.

Add a CI build configuration to catch the issue.

Test Plan

cmake -GNinja .. -DBUILD_BITCOIN_ZMQ=OFF
ninja all check check-functional

Run the build-without-zmq CI build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 28 2020, 12:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 12:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-zmq) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10449: Diff 19196.Apr 28 2020, 12:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-zmq) passed.

Fabien added a child revision: D5873: [CI] Run the tests for AArch64.Apr 28 2020, 12:58

deadalnix accepted this revision.Apr 28 2020, 13:28

This revision is now accepted and ready to land.Apr 28 2020, 13:28

Closed by commit rABCee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled (authored by Fabien). · Explain WhyApr 28 2020, 13:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled.

Fabien removed a child revision: D5873: [CI] Run the tests for AArch64.Apr 30 2020, 15:14

Fabien added a commit: rSTAGINGee1c7a40b308: [CMAKE] Fix the build with ZMQ disabled.May 5 2020, 19:11

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.sh

13 lines

src/

wallet/

CMakeLists.txt

2 lines

Diff 19199

View Options

contrib/teamcity/build-configurations.sh