Accessing an undefined array key inside an if statement doesn't fail
the if but raises an exception. This is causing the python script
relying on this to check for the EMULATOR entry in the config file to
fail. This diff adds a dummy EMULATOR entry in the autotools config.ini
template to avoid this issue.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING7677060b233d: Fix the emulator with autotools
rABC7677060b233d: Fix the emulator with autotools
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
It would be preferable that it is possible to run the tests manually rather than specifically crafted build systems only.
IMO the problems here lies with the test that assumes EMULATOR must be set, not in autotools.
Comment Actions
Every other field just need to be set as well or the tests will fail. Making them independent from the config file (and this the build system) is out of scope.
I can fix it in the python code, but since the content of the file is assumed all over the place I don't think it makes a lot of sense.