Page MenuHomePhabricator
Differential D5884

Clarify emptyIncludeConf logic
ClosedPublic
Actions

Authored by deadalnix on Apr 29 2020, 14:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING455cd82187d5: Clarify emptyIncludeConf logic
rABC455cd82187d5: Clarify emptyIncludeConf logic
Summary

Suggestion from John Newbery <john@johnnewbery.com> in
https://github.com/bitcoin/bitcoin/pull/15934#discussion_r343795528

This is a partial backport of Core PR15934 : https://github.com/bitcoin/bitcoin/pull/15934/commits/dc8e1e75487461ec9bff433144f0db831b682403

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 29 2020, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 14:36
teamcity edited the summary of this revision. (Show Details)Apr 29 2020, 14:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 29 2020, 14:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 29 2020, 14:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10471: Diff 19234.Apr 29 2020, 14:51
jasonbcox accepted this revision.Apr 29 2020, 14:59
This revision is now accepted and ready to land.Apr 29 2020, 14:59
Closed by commit rABC455cd82187d5: Clarify emptyIncludeConf logic (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyApr 29 2020, 15:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC455cd82187d5: Clarify emptyIncludeConf logic.
deadalnix added a commit: rSTAGING455cd82187d5: Clarify emptyIncludeConf logic.May 5 2020, 19:12

Revision Contents
Changeset List

PathSize
src/
util/
18 lines

Diff 19240

View Options

src/util/system.cpp

Loading...