Page MenuHomePhabricator
Differential D5909

test: Add ASSERT_DEBUG_LOG to unit test framework
ClosedPublic
Actions

Authored by deadalnix on Apr 30 2020, 15:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4bd613e56973: test: Add ASSERT_DEBUG_LOG to unit test framework
rABC4bd613e56973: test: Add ASSERT_DEBUG_LOG to unit test framework
Summary
  • logging: Add member for arbitrary print callbacks
  • test: Add ASSERT_DEBUG_LOG to unit test framework

This is a backport of Core PR16540

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 30 2020, 15:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 15:24
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 15:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 30 2020, 15:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 15:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10510: Diff 19295.Apr 30 2020, 15:39
Fabien accepted this revision.Apr 30 2020, 16:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/lib/logging.cpp
17 ↗(On Diff #19295)

braces

This revision is now accepted and ready to land.Apr 30 2020, 16:09
Closed by commit rABC4bd613e56973: test: Add ASSERT_DEBUG_LOG to unit test framework (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyApr 30 2020, 16:20
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4bd613e56973: test: Add ASSERT_DEBUG_LOG to unit test framework.
deadalnix added a commit: rSTAGING4bd613e56973: test: Add ASSERT_DEBUG_LOG to unit test framework.May 5 2020, 19:15

Revision Contents
Changeset List

PathSize
src/
4 lines
22 lines
7 lines
12 lines
24 lines
test/
1 line
lib/
30 lines
32 lines
15 lines
wallet/
test/
30 lines

Diff 19302

View Options

src/Makefile.test.include

Loading...
View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/noui.h

Loading...
View Options

src/noui.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/lib/logging.h

Loading...
View Options

src/test/lib/logging.cpp

Loading...
View Options

src/test/timedata_tests.cpp

Loading...
View Options

src/wallet/test/init_tests.cpp

Loading...