Differential D5923

Revert ContextFreeRPCCommand nonsense
ClosedPublic
Actions

Authored by deadalnix on Apr 30 2020, 22:09.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGdb3bb0625d64: Revert ContextFreeRPCCommand nonsense
rABCdb3bb0625d64: Revert ContextFreeRPCCommand nonsense

Summary

It's effectively dead code.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 30 2020, 22:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 22:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10529: Diff 19325.Apr 30 2020, 22:19

This causes too many merge conflicts to be useful.

This revision is now accepted and ready to land.Apr 30 2020, 22:27

Closed by commit rABCdb3bb0625d64: Revert ContextFreeRPCCommand nonsense (authored by deadalnix). · Explain WhyApr 30 2020, 22:45

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdb3bb0625d64: Revert ContextFreeRPCCommand nonsense.

deadalnix added a commit: rSTAGINGdb3bb0625d64: Revert ContextFreeRPCCommand nonsense.May 5 2020, 19:16

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

rpcnestedtests.cpp

2 lines

rpc/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

14 lines

server.h

22 lines

server.cpp

24 lines

wallet/

rpcdump.cpp

2 lines

rpcwallet.cpp

2 lines

zmq/

zmqrpc.cpp

2 lines

test/

lint/

check-rpc-mappings.py

2 lines

Diff 19329

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/rpc/abc.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/register.h

View Options

src/rpc/server.h

View Options

src/rpc/server.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/zmq/zmqrpc.cpp

View Options

test/lint/check-rpc-mappings.py

Revert ContextFreeRPCCommand nonsenseClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19329

src/qt/test/rpcnestedtests.cpp

src/rpc/abc.cpp

src/rpc/avalanche.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/register.h

src/rpc/server.h

src/rpc/server.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/zmq/zmqrpc.cpp

test/lint/check-rpc-mappings.py

Revert ContextFreeRPCCommand nonsense
ClosedPublic
Actions

Revision Contents
Changeset List