Page MenuHomePhabricator
Differential D5944

[backport#15288] moved remaining g_mempool references out of wallet.cpp
ClosedPublic
Actions

Authored by majcosta on May 3 2020, 18:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf9a435c39985: [backport#15288] moved remaining g_mempool references out of wallet.cpp
rABCf9a435c39985: [backport#15288] moved remaining g_mempool references out of wallet.cpp
Summary

I skipped this commit (https://github.com/bitcoin/bitcoin/pull/15288/commits/cc02c796d3517931acc861b0f9bc50e36e1c95f9) backporting PR15288
because we don't use Core's 'smart fee' functionality but later realized that the references to g_mempool in wallet/wallet.cpp still needed
to be moved to prevent problems with further refactoring. Tried to keep this change as close as possible to the original commit.

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 3 2020, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2020, 18:27
teamcity edited the summary of this revision. (Show Details)May 3 2020, 18:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 3 2020, 18:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 3 2020, 18:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10564: Diff 19389.May 3 2020, 18:37
majcosta requested review of this revision.May 3 2020, 18:37
majcosta edited the summary of this revision. (Show Details)May 3 2020, 20:28
majcosta updated this revision to Diff 19390.May 3 2020, 22:14

small correction to virtual estimateFee()'s comment

teamcity added a comment.May 3 2020, 22:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 3 2020, 22:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10565: Diff 19390.May 3 2020, 22:23
deadalnix accepted this revision.May 3 2020, 22:36
This revision is now accepted and ready to land.May 3 2020, 22:36
Closed by commit rABCf9a435c39985: [backport#15288] moved remaining g_mempool references out of wallet.cpp (authored by majcosta). · Explain WhyMay 4 2020, 08:17
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf9a435c39985: [backport#15288] moved remaining g_mempool references out of wallet.cpp.
majcosta added a commit: rSTAGINGf9a435c39985: [backport#15288] moved remaining g_mempool references out of wallet.cpp.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
3 lines
2 lines
wallet/
5 lines
9 lines
12 lines

Diff 19394

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...