Merge #14150: Add key origin support to descriptors
ClosedPublic
Actions

Authored by nakihito on May 7 2020, 23:16.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING46afc3475dab: Merge #14150: Add key origin support to descriptors
rABC46afc3475dab: Merge #14150: Add key origin support to descriptors

Summary

8afb166875 Update documentation to incude origin information (Pieter Wuille)
ff37459abc Add tests for key origin support (Pieter Wuille)
2c6281f180 Add key origin support to descriptors (Pieter Wuille)

Pull request description:

This adds support for [key origin](https://gist.github.com/sipa/e3d23d498c430bb601c5bca83523fa82#key-origin-identification) information to the descriptor parser, and exposes the resulting key path information through `FlatSigningProvider`.

There is no observable functionality from this right now, except having the `scantxoutset` RPC accept descriptors that include key origin information.

Longer term this feature helps with a potential descriptors-based walletless PSBT updater, or for importing hardware wallet xpubs (once the wallet can import descriptors).

Tree-SHA512: 399828127b2e90a2f32d81ecc30a8a9261d08f4182d5d1744f05e46b25fde1bd383c54835b0820ca668e7d17353fa92c0fb2987e211ce269e0824c9395d210c2

Backport of Core PR14150

Test Plan

ninja
ninja check
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 7 2020, 23:16

Owners added a reviewer: Restricted Owners Package.May 7 2020, 23:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 23:16

nakihito requested review of this revision.May 7 2020, 23:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10653: Diff 19833.May 7 2020, 23:26

Reformatted comment.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10657: Diff 19841.May 8 2020, 17:25

deadalnix requested changes to this revision.May 9 2020, 11:57

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/script/descriptor.cpp
81 ↗	(On Diff #19841)	braces
96 ↗	(On Diff #19841)	dito
212 ↗	(On Diff #19841)	C++ constructors.
src/test/descriptor_tests.cpp
162 ↗	(On Diff #19841)	This doesn't seems like the best formatting.