Page MenuHomePhabricator
Differential D6053

refactor: Cleanup walletinitinterface.h
ClosedPublic
Actions

Authored by deadalnix on May 12 2020, 23:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGaa7cbc34a288: refactor: Cleanup walletinitinterface.h
rABCaa7cbc34a288: refactor: Cleanup walletinitinterface.h
Summary

Forward declarations of CScheduler and CRPCTable classes are no longer
needed after ea961c3d7256c66146b4976ab1293db4a628c0de commit.
Including <string> is no longer needed after
4d4185a4f0e40c033a587871839a47cb3f89ee93 commit.

This is a backport of Core PR16830

Thrown in chainparams.h for good measure.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 12 2020, 23:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 23:28
deadalnix requested review of this revision.May 12 2020, 23:28
teamcity edited the summary of this revision. (Show Details)May 12 2020, 23:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 12 2020, 23:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 12 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 12 2020, 23:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 12 2020, 23:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10733: Diff 19976.May 12 2020, 23:42
Fabien accepted this revision.May 13 2020, 08:08
This revision is now accepted and ready to land.May 13 2020, 08:08
Closed by commit rABCaa7cbc34a288: refactor: Cleanup walletinitinterface.h (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyMay 13 2020, 12:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCaa7cbc34a288: refactor: Cleanup walletinitinterface.h.
deadalnix added a commit: rSTAGINGaa7cbc34a288: refactor: Cleanup walletinitinterface.h.May 13 2020, 12:10

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 19988

View Options

src/walletinitinterface.h

Loading...