Prefer the PIC version when available, and pull the dependencies as
needed.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGa0f331bafdd8: [CMAKE] Improve the FindJemalloc module
rABCa0f331bafdd8: [CMAKE] Improve the FindJemalloc module
cmake -GNinja .. -DUSE_JEMALLOC_EXPERIMENTAL=ON
On Debian, check in the cmake output that libdl is required.
ninja all check
Require D6038:
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake -DUSE_JEMALLOC_EXPERIMENTAL=ON
Check in the cmake output that libdl is NOT required.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| cmake/modules/FindJemalloc.cmake | ||
|---|---|---|
| 49 ↗ | (On Diff #19978) | Is there a way to detect if dl is needed? Depending on jemalloc's build options it may or may not be a dependency. |
| cmake/modules/FindJemalloc.cmake | ||
|---|---|---|
| 56 ↗ | (On Diff #19997) | Why not provide a source file directly rather than go with this strange dance? |
| 61 ↗ | (On Diff #19997) | You probably want to check for a dl related error, because if not, then you'll add dl as a dependency numerous times and then fail to build at the end. |
| 79 ↗ | (On Diff #19997) | You want to check if libdl is missing. Stating it this way and changing the code accordingly will make everything both clearer and more robust. |
Comment Actions
Use a source file rather than generating it.
Check the output to make sure the failure is related to libdl missing.
Comment Actions
There are a few problems with this. Because they are either trivials, or on the other may not have a solution, I'm accepting it this.
| cmake/modules/FindJemalloc.cmake | ||
|---|---|---|
| 67 ↗ | (On Diff #20000) | You might want to use something a bit more specific as regex. |
| 71 ↗ | (On Diff #20000) | Presumably we verified this is missing, so filtering based on windows or not does not seems necessary. |
| 75 ↗ | (On Diff #20000) | First, this is a confusing error message. You need to point out that jemalloc was found, but that we couldn't build a simple test proram with it. Solution are: verify jemalloc is installed properly or disable it. In the case dl was missing, but there is also another problem, then this message won't show up and failure will happen at link time later. I guess this is okay. |