Page MenuHomePhabricator
Differential D6066

Fix string layout in rpc/rawtransaction.cpp
ClosedPublic
Actions

Authored by nakihito on May 14 2020, 00:35.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp
rABC3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp
Summary

The layout of some of the strings was incorrect.

Test Plan
ninja
arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.May 14 2020, 00:35
Owners added a reviewer: Restricted Owners Package.May 14 2020, 00:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 00:35
nakihito requested review of this revision.May 14 2020, 00:35
teamcity added a comment.May 14 2020, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 00:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Harbormaster completed remote builds in B10757: Diff 20037.May 14 2020, 00:36
teamcity added a comment.May 14 2020, 00:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.May 14 2020, 00:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.May 14 2020, 00:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 00:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 00:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 00:52
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.May 14 2020, 00:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 00:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 00:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

majcosta accepted this revision.May 14 2020, 01:01
This revision is now accepted and ready to land.May 14 2020, 01:01
teamcity added a comment.May 14 2020, 01:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Closed by commit rABC3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp (authored by nakihito). · Explain WhyMay 14 2020, 01:10
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp.
nakihito added a commit: rSTAGING3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp.May 14 2020, 01:15

Revision Contents
Changeset List

PathSize
src/
rpc/
122 lines

Diff 20038

View Options

src/rpc/rawtransaction.cpp

Loading...