Page MenuHomePhabricator
Differential D6071

Merge #18641: test: Create cached blocks not in the future
ClosedPublic
Actions

Authored by jasonbcox on May 14 2020, 17:04.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGaff6784475fb: Merge #18641: test: Create cached blocks not in the future
rABCaff6784475fb: Merge #18641: test: Create cached blocks not in the future
Summary

fa320975411af4f0e41771d89958a77fd7a2284b test: Create cached blocks not in the future (MarcoFalke)

Pull request description:

This avoids test failures when tests assume blocks are not from the future, like in wallet_dump: https://cirrus-ci.com/task/6607130193035264?command=ci#L3306

ACKs for top commit:

jonatack:
  ACK fa320975411af4f0e41771d89958a77fd7a2284b

Tree-SHA512: 60b6882e0e1df8c5d67f034533407a45d3685983891b67ff4631072bfd0a93a325c7ca18758d7a2df252e4fcdb7c87321cb1e84458b22782e57e719eec634c22

Backport of Core PR18641

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 14 2020, 17:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 17:04
jasonbcox requested review of this revision.May 14 2020, 17:04
teamcity edited the summary of this revision. (Show Details)May 14 2020, 17:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 17:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 17:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 17:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10763: Diff 20047.May 14 2020, 17:16
nakihito accepted this revision.May 14 2020, 18:00
This revision is now accepted and ready to land.May 14 2020, 18:00
Closed by commit rABCaff6784475fb: Merge #18641: test: Create cached blocks not in the future (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyMay 14 2020, 19:43
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCaff6784475fb: Merge #18641: test: Create cached blocks not in the future.
jasonbcox added a commit: rSTAGINGaff6784475fb: Merge #18641: test: Create cached blocks not in the future.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
13 lines

Diff 20059

View Options

test/functional/test_framework/test_framework.py

Loading...