Page MenuHomePhabricator
Differential D6117

Fix Flake8 E741 errors
ClosedPublic
Actions

Authored by Fabien on May 18 2020, 16:17.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe02a92dc3354: Fix Flake8 E741 errors
rABCe02a92dc3354: Fix Flake8 E741 errors
Summary

These errors are added in newer versions of pycodestyle.
https://www.flake8rules.com/rules/E741.html

Test Plan

With pycodestyle >= 2.6.0

arc lint --everything

Check there is no E741 error.

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 18 2020, 16:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 16:17
Fabien requested review of this revision.May 18 2020, 16:17
teamcity added a comment.May 18 2020, 16:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 16:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 16:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 16:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 16:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 18 2020, 16:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10825: Diff 20214.May 18 2020, 16:36
jasonbcox accepted this revision.May 18 2020, 16:51
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/messages.py
77 ↗(On Diff #20214)

Nit: cs doesn't mean anything about the variable or what it contains. list or something would be better here (assuming l was supposed to be a list in the first place).

This revision is now accepted and ready to land.May 18 2020, 16:51
Fabien updated this revision to Diff 20221.May 18 2020, 18:35

Update variable name.

teamcity added a comment.May 18 2020, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 18:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 18:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 18 2020, 18:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10830: Diff 20221.May 18 2020, 18:49
jasonbcox accepted this revision.May 18 2020, 18:56
Closed by commit rABCe02a92dc3354: Fix Flake8 E741 errors (authored by Fabien). · Explain WhyMay 18 2020, 18:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe02a92dc3354: Fix Flake8 E741 errors.
Fabien added a commit: rSTAGINGe02a92dc3354: Fix Flake8 E741 errors.May 18 2020, 19:00

Revision Contents
Changeset List

PathSize
test/
functional/
14 lines
test_framework/
34 lines
4 lines
fuzz/
6 lines
lint/
2 lines

Diff 20226

View Options

test/functional/p2p_compactblocks.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/fuzz/test_runner.py

Loading...
View Options

test/lint/lint-python-format.py

Loading...