Page MenuHomePhabricator

Merge #14565: Overhaul importmulti logic and Make getaddressinfo return solvability
AbandonedPublic

Authored by nakihito on May 18 2020, 23:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

eacff95de Add release notes (Pieter Wuille)
bdacbda25 Overhaul importmulti logic (Pieter Wuille)

Pull request description:

This is an alternative to #14558 (it will warn when fields are being ignored). In addition:
* It makes sure no changes to the wallet are made when an error in the input exists.
* It validates all arguments, and will fail if anything fails to parse.
* Adds a whole bunch of sanity checks

Tree-SHA512: fdee0b6aca8c643663f0bc295a7c1d69c1960951493b06abf32c58977f3e565f75918dbd0402dde36e508dc746c9310a968a0ebbacccc385a57ac2a68b49c1d0

Backport of Core PR14565
Also partial backport of Core PR14454
https://github.com/bitcoin/bitcoin/pull/14454/commits/201451b1ca3c6db3b13f9491a81db5b120b864bb
I included the last commit of PR14454 with this one because there would be no tests for it by itself.

Test Plan
ninja
ninja check-functional
./bitcoind
./bitcoin-cli help getaddressinfo

Verify help text.

Event Timeline

nakihito created this revision.May 18 2020, 23:22
Owners added a reviewer: Restricted Owners Package.May 18 2020, 23:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 23:22
nakihito requested review of this revision.May 18 2020, 23:22
teamcity edited the summary of this revision. (Show Details)May 18 2020, 23:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 18 2020, 23:40
deadalnix added a subscriber: deadalnix.

Just No. I just spent my whole day untangling this mess because there are a ton of patches such as this one that pic various parts of various PR, preferably out of order.

This revision now requires changes to proceed.May 18 2020, 23:40
nakihito abandoned this revision.May 21 2020, 23:21