Page MenuHomePhabricator

Add address_types test
ClosedPublic

Authored by deadalnix on May 18 2020, 23:35.

Details

Summary

Improvements and cleanups by John Newbery

This is from PR11403 : https://github.com/bitcoin/bitcoin/pull/11403/commits/b224a47a1a5feac380506abff63fae91d7a93b39

We initially decided not to backport it because we don't have this feature, but it turns out it exercice various parts of the code and is useful. In addition, it makes backport easier.

Also include a trick similar to PR17124 to significantly speedup the test.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.May 18 2020, 23:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 23:35
deadalnix requested review of this revision.May 18 2020, 23:35
teamcity edited the summary of this revision. (Show Details)May 18 2020, 23:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

2020-05-18T23:36:19.474000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:19.524000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:19.525000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_resendwallettransactions_494 on exit
2020-05-18T23:36:19.525000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py
[23:37:02]i:			 [wallet_txn_clone.py] Test ignored: wallet_txn_clone.py
[23:37:02]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-18T23:36:47.250000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:47.300000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:47.300000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_txn_clone_541 on exit
2020-05-18T23:36:47.300000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py --mineblock
[23:37:02]i:			 [wallet_txn_clone.py --mineblock] Test ignored: wallet_txn_clone.py --mineblock
[23:37:02]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-18T23:36:41.365000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:41.416000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:41.416000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_txn_clone_522 on exit
2020-05-18T23:36:41.416000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py
[23:37:02]i:			 [wallet_txn_doublespend.py] Test ignored: wallet_txn_doublespend.py
[23:37:02]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-18T23:36:55.959000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:56.010000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:56.010000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_txn_doublespend_574 on exit
2020-05-18T23:36:56.010000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py --mineblock
[23:37:02]i:			 [wallet_txn_doublespend.py --mineblock] Test ignored: wallet_txn_doublespend.py --mineblock
[23:37:02]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-18T23:36:41.484000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:41.535000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:41.535000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_txn_doublespend_523 on exit
2020-05-18T23:36:41.535000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_zapwallettxes.py
[23:37:02]i:			 [wallet_zapwallettxes.py] Test ignored: wallet_zapwallettxes.py
[23:37:02]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-18T23:36:38.442000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-18T23:36:38.492000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:36:38.492000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_zapwallettxes_512 on exit
2020-05-18T23:36:38.492000Z TestFramework (INFO): Test skipped
[23:37:02]i:		 [Bitcoin ABC functional tests] wallet_address_types.py
[23:37:02]i:			 [wallet_address_types.py] [Test Output]
2020-05-18T23:36:58.211000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_address_types_597
2020-05-18T23:37:00.943000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 163, in main
    self.run_test()
  File "/work/test/functional/wallet_address_types.py", line 90, in run_test
    2, [uncompressed_1, uncompressed_2])['address'], True, 'legacy')
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 148, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2020-05-18T23:37:00.997000Z TestFramework (INFO): Stopping nodes
2020-05-18T23:37:01.613000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_address_types_597
2020-05-18T23:37:01.613000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_address_types_597/test_framework.log
2020-05-18T23:37:01.613000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/test_runner_₿₵_  _20200518_233617/wallet_address_types_597' to consolidate all logs
[23:37:07]E:	 [Step 1/2] Failed tests detected
[23:37:09]W:	 [Step 1/2] Process exited with code 1
[23:37:09]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_address_types.py

deadalnix updated this revision to Diff 20251.May 18 2020, 23:42

Skip if no wallet.

majcosta accepted this revision.May 18 2020, 23:59
This revision is now accepted and ready to land.May 18 2020, 23:59
This revision was automatically updated to reflect the committed changes.