Page MenuHomePhabricator
Differential D6141

[wallet] Refactor ProcessImport()
ClosedPublic
Actions

Authored by deadalnix on May 19 2020, 15:42.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING76e7ff60e42b: [wallet] Refactor ProcessImport()
rABC76e7ff60e42b: [wallet] Refactor ProcessImport()
Summary

This commit is move-only and doesn't make any functional changes. It
simply moves code around within ProcessImport() in preparation for
refactors in the next commits.

This is a partial backport of Core PR14491 : https://github.com/bitcoin/bitcoin/pull/14491/commits/a1b25e12a5f57048a4639964d57c0b46eb84cd4e

Some loop variable names have been changed to make sure we don't have shaddowing going on.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 19 2020, 15:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 15:42
deadalnix requested review of this revision.May 19 2020, 15:42
teamcity edited the summary of this revision. (Show Details)May 19 2020, 15:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 19 2020, 15:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 15:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 15:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 16:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10857: Diff 20280.May 19 2020, 16:01
jasonbcox accepted this revision.May 19 2020, 16:18
This revision is now accepted and ready to land.May 19 2020, 16:18
Closed by commit rABC76e7ff60e42b: [wallet] Refactor ProcessImport() (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 19 2020, 19:02
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC76e7ff60e42b: [wallet] Refactor ProcessImport().
deadalnix added a commit: rSTAGING76e7ff60e42b: [wallet] Refactor ProcessImport().May 19 2020, 19:05

Revision Contents
Changeset List

PathSize
src/
wallet/
67 lines

Diff 20303

View Options

src/wallet/rpcdump.cpp

Loading...