Page MenuHomePhabricator
Differential D6149

[backport#14820] test: Fix descriptor_tests not checking ToString output of public descriptors
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 00:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5ab3f9d832ed: [backport#14820] test: Fix descriptor_tests not checking ToString output of…
rABC5ab3f9d832ed: [backport#14820] test: Fix descriptor_tests not checking ToString output of…
Summary

c77f09230b Fix descriptor_tests not checking ToString output of public descriptors (Russell Yanofsky)

Pull request description:

This fixes a minor test bug introduced in #13697 that I noticed while reviewing #14646

Tree-SHA512: efed91200cdff5f86ba5de3461ac00759d285e2905f6cb24cea15d3e23e0581ce5fc14b24a40db093f7ebd662ee1ee2cf67f8798bac1903a78298eda08909cfb

This is a backport of Core PR14820

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 00:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 00:34
majcosta requested review of this revision.May 20 2020, 00:34
teamcity edited the summary of this revision. (Show Details)May 20 2020, 00:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 00:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 00:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 00:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 00:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 00:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 00:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10873: Diff 20317.May 20 2020, 00:44
Fabien accepted this revision.May 20 2020, 08:31
This revision is now accepted and ready to land.May 20 2020, 08:31
Closed by commit rABC5ab3f9d832ed: [backport#14820] test: Fix descriptor_tests not checking ToString output of… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 20 2020, 12:48
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5ab3f9d832ed: [backport#14820] test: Fix descriptor_tests not checking ToString output of….
majcosta added a commit: rSTAGING5ab3f9d832ed: [backport#14820] test: Fix descriptor_tests not checking ToString output of….

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 20350

View Options

src/test/descriptor_tests.cpp

Loading...