Page MenuHomePhabricator
Differential D6232

Merge #14417: Fix listreceivedbyaddress not taking address as a string
ClosedPublic
Actions

Authored by nakihito on May 22 2020, 20:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC76d7d0212718: Merge #14417: Fix listreceivedbyaddress not taking address as a string
Summary

d4d70eda33 Fix listreceivedbyaddress not taking address as a string (Eric Scrivner)

Pull request description:

Fixes #14173. Add the patch in #14173 and include a regression test.

Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5

Backport of Core PR14417

Test Plan
ninja
ninja check
ninja check-functional

Verify the changes to wallet_listreceivedby causes it to fail on master if the changes to rpc/client.cpp from this patch are reverted.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.May 22 2020, 20:52
Owners added a reviewer: Restricted Owners Package.May 22 2020, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 20:52
nakihito requested review of this revision.May 22 2020, 20:52
teamcity edited the summary of this revision. (Show Details)May 22 2020, 20:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 20:52

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 20:52

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 20:52

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 20:53

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 20:56

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 21:03

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10992: Diff 20546.May 22 2020, 21:03
deadalnix accepted this revision.May 22 2020, 21:15
This revision is now accepted and ready to land.May 22 2020, 21:15
Closed by commit rABC76d7d0212718: Merge #14417: Fix listreceivedbyaddress not taking address as a string (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMay 22 2020, 21:27
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC76d7d0212718: Merge #14417: Fix listreceivedbyaddress not taking address as a string.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
1 line
test/
functional/
4 lines

Diff 20547

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

test/functional/wallet_listreceivedby.py

Loading...