Page MenuHomePhabricator

[autotools-build] Disable _FORTIFY_SOURCE when enable-debug
ClosedPublic

Authored by majcosta on May 25 2020, 14:21.

Details

Summary

Since enable-debug disables optimization entirely, _FORTIFY_SOURCE
does nothing as it requires some kind of optimization enabled. It
instead produces a bunch of useless warnings. So explicitly disable
it when enable-debug so that those warnings are not produced.


Backport of Core PR17033

Test Plan
mkdir build-autotools
../autogen.sh
../configure --enable-deprecated-build-system --enable-debug

see that -U_FORTIFY_SOURCE and -D_FORTIFY_SOURCE=2 are absent from CXX flags, while

../configure --enable-deprecated-build-system

has them set

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 25 2020, 14:47