Differential D6244

[autotools-build] Disable _FORTIFY_SOURCE when enable-debug
ClosedPublic
Actions

Authored by majcosta on May 25 2020, 14:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfc846cd03617: [autotools-build] Disable _FORTIFY_SOURCE when enable-debug

Summary

Since enable-debug disables optimization entirely, _FORTIFY_SOURCE
does nothing as it requires some kind of optimization enabled. It
instead produces a bunch of useless warnings. So explicitly disable
it when enable-debug so that those warnings are not produced.

Backport of Core PR17033

Test Plan

mkdir build-autotools
../autogen.sh
../configure --enable-deprecated-build-system --enable-debug

see that -U_FORTIFY_SOURCE and -D_FORTIFY_SOURCE=2 are absent from CXX flags, while

../configure --enable-deprecated-build-system

has them set

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 25 2020, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2020, 14:21

majcosta requested review of this revision.May 25 2020, 14:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B11011: Diff 20583.May 25 2020, 14:33

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Fabien accepted this revision.May 25 2020, 14:47

This revision is now accepted and ready to land.May 25 2020, 14:47

Closed by commit rABCfc846cd03617: [autotools-build] Disable _FORTIFY_SOURCE when enable-debug (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyMay 25 2020, 15:00

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCfc846cd03617: [autotools-build] Disable _FORTIFY_SOURCE when enable-debug.

Revision Contents
Changeset List

Path

Size

configure.ac

15 lines

Diff 20587

View Options

[autotools-build] Disable _FORTIFY_SOURCE when enable-debugClosedPublicActions