Page MenuHomePhabricator
Differential D6263

wallet/rpc: sendrawtransaction maxfeerate
ClosedPublic
Actions

Authored by deadalnix on May 26 2020, 21:14.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1d4e5281a755: wallet/rpc: sendrawtransaction maxfeerate
Summary
  • test: Refactor vout fetches in rpc_rawtransaction
  • wallet/rpc: add maxfeerate parameter to sendrawtransaction
  • wallet/rpc: add maxfeerate parameter to testmempoolaccept

This is a backport of Core PR13541

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 26 2020, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 21:14
deadalnix requested review of this revision.May 26 2020, 21:14
teamcity edited the summary of this revision. (Show Details)May 26 2020, 21:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 21:15

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 21:15

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 21:15

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 21:17

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 21:19

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 21:27

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11041: Diff 20628.May 26 2020, 21:27
majcosta added a subscriber: majcosta.May 26 2020, 21:51
majcosta accepted this revision.May 26 2020, 22:15
This revision is now accepted and ready to land.May 26 2020, 22:15
Closed by commit rABC1d4e5281a755: wallet/rpc: sendrawtransaction maxfeerate (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyMay 26 2020, 22:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1d4e5281a755: wallet/rpc: sendrawtransaction maxfeerate.

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
70 lines
test/
functional/
2 lines
4 lines
34 lines
2 lines
48 lines
test_framework/
2 lines
4 lines
4 lines

Diff 20629

View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/rpc_createmultisig.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/test_framework/blocktools.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...