Differential D6286

[backport#15458] refactor: Drop redundant wallet reference
ClosedPublic
Actions

Authored by majcosta on May 28 2020, 20:35.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC02766ca19f53: [backport#15458] refactor: Drop redundant wallet reference

Summary

53b310390c refactor: Drop redundant wallet reference (João Barbosa)

Pull request description:

Removes the redudant wallet reference from `WalletImpl`.

```cpp
// before:
std::shared_ptr<CWallet> m_shared_wallet;
CWallet& m_wallet;

// after
std::shared_ptr<CWallet> m_wallet;
```

https://github.com/bitcoin/bitcoin/pull/15458/commits/53b310390cc72a034911a8d6236b472a22c62227

Backport of Core PR15458

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2020, 20:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 20:35

majcosta requested review of this revision.May 28 2020, 20:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11074: Diff 20683.May 28 2020, 20:45

deadalnix accepted this revision.May 29 2020, 11:43

This revision is now accepted and ready to land.May 29 2020, 11:43

Closed by commit rABC02766ca19f53: [backport#15458] refactor: Drop redundant wallet reference (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 29 2020, 14:18

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC02766ca19f53: [backport#15458] refactor: Drop redundant wallet reference.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.cpp

245 lines

Diff 20699

View Options

[backport#15458] refactor: Drop redundant wallet referenceClosedPublicActions