Differential D6287

[backport#14518] rpc: Always throw in getblockstats if -txindex is required
ClosedPublic
Actions

Authored by majcosta on May 28 2020, 22:59.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCb569951c2c15: [backport#14518] rpc: Always throw in getblockstats if -txindex is required

Summary

3be209d103297aaf2fe4711e237a65046488ea19 rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

Previously blocks with only the coinbase transaction didn't cause
the RPC error even if the requested stats required -txindex and
it wasn't enabled.

Fixes #14499.

https://github.com/bitcoin/bitcoin/pull/14518/commits/3be209d103297aaf2fe4711e237a65046488ea19

Backport of Core PR14518

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2020, 22:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 22:59

majcosta requested review of this revision.May 28 2020, 22:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11076: Diff 20688.May 28 2020, 23:09

deadalnix accepted this revision.May 29 2020, 11:44

This revision is now accepted and ready to land.May 29 2020, 11:44

Closed by commit rABCb569951c2c15: [backport#14518] rpc: Always throw in getblockstats if -txindex is required (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyMay 29 2020, 14:23

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb569951c2c15: [backport#14518] rpc: Always throw in getblockstats if -txindex is required.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

12 lines

test/

functional/

rpc_getblockstats.py

2 lines

Diff 20700

View Options

src/rpc/blockchain.cpp