Page MenuHomePhabricator
Differential D6288

[backport#15139] Replace use of BEGIN and END macros on uint256
ClosedPublic
Actions

Authored by majcosta on May 28 2020, 23:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0a1db10c79f0: [backport#15139] Replace use of BEGIN and END macros on uint256
Summary

Replace use of BEGIN and END macros on uint256 with begin() and
end() methods in the Merkle tree code.

https://github.com/bitcoin/bitcoin/pull/15139/commits/7fa238c701b5b6d4f78b92334e38fac466ec0eb2

Partial backport of Core PR15139

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2020, 23:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 23:18
majcosta requested review of this revision.May 28 2020, 23:18
teamcity edited the summary of this revision. (Show Details)May 28 2020, 23:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 28 2020, 23:18

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 23:18

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 23:18

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 23:19

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 23:21

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 23:27

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11077: Diff 20689.May 28 2020, 23:27
deadalnix accepted this revision.May 29 2020, 11:40
This revision is now accepted and ready to land.May 29 2020, 11:40
Closed by commit rABC0a1db10c79f0: [backport#15139] Replace use of BEGIN and END macros on uint256 (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyMay 29 2020, 15:46
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC0a1db10c79f0: [backport#15139] Replace use of BEGIN and END macros on uint256.

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
4 lines

Diff 20702

View Options

src/merkleblock.cpp

Loading...
View Options

src/test/merkle_tests.cpp

Loading...