Page MenuHomePhabricator

Fix WSL file locking by using flock instead of fcntl
ClosedPublic

Authored by nakihito on May 29 2020, 19:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl
Summary

Co-authored-by: sipa <pieter@wuille.net>

Backport of Core PR18700

Test Plan

On WSL

ninja check
ninja check-functional

Confirm all tests pass except feature_proxy.py (fails), rpc_bind.py (skipped), and interface_zmq.py (skipped).

Using two different consoles:

src/bitcoind

Verify this fails on the second console with the following error:

Error: Cannot obtain a lock on data directory <path>/.bitcoin. Bitcoin ABC is probably already running.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.May 29 2020, 19:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 29 2020, 20:19