Paths

Table of Contentst

Fix WSL file locking by using flock instead of fcntl
ClosedPublic
Actions

Authored by nakihito on May 29 2020, 19:36.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl

Summary

Co-authored-by: sipa <pieter@wuille.net>

Backport of Core PR18700

Test Plan

On WSL

ninja check
ninja check-functional

Confirm all tests pass except feature_proxy.py (fails), rpc_bind.py (skipped), and interface_zmq.py (skipped).

Using two different consoles:

src/bitcoind

Verify this fails on the second console with the following error:

Error: Cannot obtain a lock on data directory <path>/.bitcoin. Bitcoin ABC is probably already running.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 29 2020, 19:36

Owners added a reviewer: Restricted Owners Package.May 29 2020, 19:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 19:36

nakihito requested review of this revision.May 29 2020, 19:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

nakihito edited the test plan for this revision. (Show Details)May 29 2020, 19:41

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11092: Diff 20713.May 29 2020, 19:46

jasonbcox accepted this revision.May 29 2020, 20:19

This revision is now accepted and ready to land.May 29 2020, 20:19

Closed by commit rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by nakihito). · Explain WhyMay 29 2020, 20:39

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl.

Revision Contents
Changeset List

Path

Size

src/

fs.cpp

38 lines

Diff 20716

View Options

Fix WSL file locking by using flock instead of fcntlClosedPublicActions