Page MenuHomePhabricator
Differential D6316

Merge #16481: Trivial: add missing space
ClosedPublic
Actions

Authored by nakihito on Jun 1 2020, 17:16.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC9e6bebaac242: Merge #16481: Trivial: add missing space
Summary

16b3748189a300a32a3016c22b1dfdca13485bac Trivial: add missing space (David A. Harding)

Pull request description:

A space was lost when the `PACKAGE_NAME` variable was introduced at https://github.com/bitcoin/bitcoin/pull/16366/files#diff-6e30027c2045842fe842430d98d099fbR143 , e.g. when running `bitcoind -daemon` on Linux before this commit, I see `Bitcoin Coredaemon starting`.  This commit adds back the space.

ACKs for top commit:

fanquake:
  ACK 16b3748189a300a32a3016c22b1dfdca13485bac

Tree-SHA512: 3b0c5ed91838f0254b0aa064d1839f90fb64b2ade82bc3f6233d287b553528da5315017cb9a1d3f2b1882a010343b18a5308ae63ca4e3d47e83e8c5b532ddf5f

Test Plan
ninja
./bitcoind -daemon

Verify output is Bitcoin ABC daemon starting

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 1 2020, 17:16
Owners added a reviewer: Restricted Owners Package.Jun 1 2020, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2020, 17:16
nakihito requested review of this revision.Jun 1 2020, 17:16
teamcity added a comment.Jun 1 2020, 17:17

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 17:18

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 17:20

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 17:20

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 17:21

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 17:29

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11120: Diff 20761.Jun 1 2020, 17:29
jasonbcox accepted this revision.Jun 1 2020, 17:37
This revision is now accepted and ready to land.Jun 1 2020, 17:37
Closed by commit rABC9e6bebaac242: Merge #16481: Trivial: add missing space (authored by fanquake <fanquake@gmail.com>, committed by nakihito). · Explain WhyJun 1 2020, 17:46
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9e6bebaac242: Merge #16481: Trivial: add missing space.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 20764

View Options

src/bitcoind.cpp

Loading...