Page MenuHomePhabricator
Differential D6318

Merge #13507: RPC: Fix parameter count check for importpubkey
ClosedPublic
Actions

Authored by nakihito on Jun 1 2020, 21:31.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC55beeca040c1: Merge #13507: RPC: Fix parameter count check for importpubkey
Summary

3f72d04e29caf247a3fee92f86fe0d250d578914 Fix parameter count check for importpubkey. (Kristaps Kaupe)

Pull request description:

Found this while working on #13464. Parameter count check for `importpubkey` was wrong.

Tree-SHA512: aba41b666c6493379f320be5e3e438a6cad1a96429102ff4428c092c48f29c2eead2195792c0b018296f20e1c42eb091dd5b9886c42cecbb1f0d03d5def14705

Backport of Core PR13507

Test Plan
ninja
src/bitcoind
src/bitcoin-cli importpubkey "mypubkey" "testing" false 5

Verify RPC error occurs.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 1 2020, 21:31
Owners added a reviewer: Restricted Owners Package.Jun 1 2020, 21:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2020, 21:31
nakihito requested review of this revision.Jun 1 2020, 21:31
teamcity edited the summary of this revision. (Show Details)Jun 1 2020, 21:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Jun 1 2020, 21:31

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 21:31

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 21:31

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 21:33

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 21:34

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 21:40

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11124: Diff 20767.Jun 1 2020, 21:40
deadalnix accepted this revision.Jun 1 2020, 22:19
This revision is now accepted and ready to land.Jun 1 2020, 22:19
Closed by commit rABC55beeca040c1: Merge #13507: RPC: Fix parameter count check for importpubkey (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 1 2020, 22:46
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC55beeca040c1: Merge #13507: RPC: Fix parameter count check for importpubkey.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines

Diff 20774

View Options

src/wallet/rpcdump.cpp

Loading...