Page MenuHomePhabricator
Differential D6353

Merge #12856: Tests: Add Metaclass for BitcoinTestFramework
ClosedPublic
Actions

Authored by jasonbcox on Jun 3 2020, 21:26.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rABC53e142a7ed44: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework
Summary

c9cce0a Tests: Add Metaclass for BitcoinTestFramework (Will Ayd)

Pull request description:

BitcoinTestFramework instructs developers in its docstring to override
`set_test_params` and `run_test` in subclasses while being sure NOT to
override `__init__` and `main` . This change adds a metaclass to ensure
that developers adhere to that protocol, raising a ``TypeError`` in
instances where they have not.

closes #12835

Tree-SHA512: 5a47a7ead1f18361138cad4374747c4a8f29d25506f7b2c2a8c1c966a0b65e5ccf7317f9a078df8680fdab5d3fb71fee46a159c9f381878a3683c1e9f874abbe

Backport of Core PR12856

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 3 2020, 21:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2020, 21:26
jasonbcox requested review of this revision.Jun 3 2020, 21:26
teamcity edited the summary of this revision. (Show Details)Jun 3 2020, 21:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11173: Diff 20848.Jun 3 2020, 21:36
nakihito accepted this revision.Jun 4 2020, 00:05
This revision is now accepted and ready to land.Jun 4 2020, 00:05
Closed by commit rABC53e142a7ed44: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 4 2020, 17:02
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC53e142a7ed44: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
22 lines

Diff 20902

View Options

test/functional/test_framework/test_framework.py

Loading...