Differential D6411

Log when an import is being skipped because we already have it
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2020, 17:04.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC3c4a3c0cf1cc: Log when an import is being skipped because we already have it

Summary

Behavior Changes:

Those pubkeys being imported with add_keypool set and are already in the wallet will no longer be added to the keypool

This is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/fae7a5befd0b8746d84a6fde575e5b4ea46cb3c4

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 6 2020, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 17:04

deadalnix requested review of this revision.Jun 6 2020, 17:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11260: Diff 20996.Jun 6 2020, 17:15

majcosta accepted this revision.Jun 7 2020, 00:11

This revision is now accepted and ready to land.Jun 7 2020, 00:11

Closed by commit rABC3c4a3c0cf1cc: Log when an import is being skipped because we already have it (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 7 2020, 01:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC3c4a3c0cf1cc: Log when an import is being skipped because we already have it.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

24 lines

Diff 21026

View Options

Log when an import is being skipped because we already have itClosedPublicActions