Page MenuHomePhabricator
Differential D6412

Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2020, 17:25.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC7952f06f906c: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and…
Summary

Behavior changes:

  • If we already have the key, it's wpkh script will still be added, although it should already be there

Tis is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/c6a827424711333f6f66cf5f9d79e0e6884769de

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 6 2020, 17:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 17:25
deadalnix requested review of this revision.Jun 6 2020, 17:25
teamcity edited the summary of this revision. (Show Details)Jun 6 2020, 17:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)Jun 6 2020, 17:27
Harbormaster completed remote builds in B11261: Diff 20997.Jun 6 2020, 17:35
majcosta accepted this revision.Jun 7 2020, 20:58
This revision is now accepted and ready to land.Jun 7 2020, 20:58
Closed by commit rABC7952f06f906c: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 7 2020, 21:30
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC7952f06f906c: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and….

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines

Diff 21058

View Options

src/wallet/rpcdump.cpp

Loading...