[bugfix] prevent nodes from banning other nodes in ABC tests
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 18:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC44f14ad4471b: [bugfix] prevent nodes from banning other nodes in ABC tests

Summary

Core PR16898 changes the test_framework to use connect_nodes instead of
connect_nodes_bi, this changes the network topology of the tests which
led some of our abc-* tests to fail.

according to the logs nodes were disconnecting the other, these changes
add a -whitelist=noban@127.0.0.1 to prevent them from doing so
allowing the tests to complete

Test Plan

ninja
test_runner.py abc-finalize-block abc-parkedchain

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 8 2020, 18:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 18:09

majcosta requested review of this revision.Jun 8 2020, 18:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11324: Diff 21104.Jun 8 2020, 18:23

deadalnix accepted this revision.Jun 8 2020, 20:41

This revision is now accepted and ready to land.Jun 8 2020, 20:41

Closed by commit rABC44f14ad4471b: [bugfix] prevent nodes from banning other nodes in ABC tests (authored by majcosta). · Explain WhyJun 8 2020, 22:08

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC44f14ad4471b: [bugfix] prevent nodes from banning other nodes in ABC tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-finalize-block.py

2 lines

abc-parkedchain.py

2 lines

Diff 21125

View Options

test/functional/abc-finalize-block.py