Page MenuHomePhabricator
Differential D6476

Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive
ClosedPublic
Actions

Authored by nakihito on Jun 9 2020, 00:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc1e1a85bd303: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive
Summary

87aa0b48afe5a070e6e11e502a1803da6add5197 netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f32bbcd7ef18db772290954161806e609e netaddress: Fix indentation in IsLocal (Carl Dong)

Pull request description:

This also makes the comment match the IPv6 comment just below this hunk.

Tree-SHA512: 9b91195e71e18156c9e013f63a6d430c67951aabb4a0c2f48f3bf852570c13887572b9e2fa52f4e1beba8685a9cae8949d4d03cd618a78f88566cf9e85dc64a8

Backport of Core PR15343

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 9 2020, 00:42
Owners added a reviewer: Restricted Owners Package.Jun 9 2020, 00:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2020, 00:42
nakihito requested review of this revision.Jun 9 2020, 00:42
teamcity edited the summary of this revision. (Show Details)Jun 9 2020, 00:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11346: Diff 21134.Jun 9 2020, 00:52
Fabien accepted this revision.Jun 9 2020, 06:51
This revision is now accepted and ready to land.Jun 9 2020, 06:51
Closed by commit rABCc1e1a85bd303: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 18:31
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc1e1a85bd303: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 21178

View Options

src/netaddress.cpp

Loading...