Paths

Table of Contentst

Differential D6485

Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill
ClosedPublic
Actions

Authored by jasonbcox on Jun 9 2020, 18:23.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC910e12658934: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill

Summary

df9e15f092c18a8047f09307576c2b77b9c8d01c refactor: Improve CRollingBloomFilter::reset by using std::fill (João Barbosa)
d2dbc7da26e1ca40200521c05a0b1ca75578acd2 bench: Add benchmark for CRollingBloomFilter::reset (João Barbosa)

Pull request description:

Cleaner code. Also improves performance with `--enable-debug` (which is meaningless to non-developers).

Before:
```
# Benchmark, evals, iterations, total, min, max, median
RollingBloomReset, 5, 150, 19.3008, 0.0254917, 0.0259195, 0.0257395
```
After:
```
# Benchmark, evals, iterations, total, min, max, median
RollingBloomReset, 5, 150, 5.43269, 0.00720651, 0.00729697, 0.00724854
```

ACKs for commit df9e15:

MarcoFalke:
  re-utACK df9e15f092
jamesob:
  re-utACK https://github.com/bitcoin/bitcoin/pull/16073/commits/df9e15f092c18a8047f09307576c2b77b9c8d01c

Tree-SHA512: 22038411dfd41afad77b17a3da9ee04476ffbd4d215dcf47bdd9f14588759bc328a55d958dcebc2036b52ce4c56f79b1284eae11e56ddfaf21f0b2ee1c6a914a

Backport of Core PR16073

Test Plan

ninja check bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 9 2020, 18:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2020, 18:23

jasonbcox requested review of this revision.Jun 9 2020, 18:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11362: Diff 21173.Jun 9 2020, 18:52

majcosta accepted this revision.Jun 9 2020, 19:00

This revision is now accepted and ready to land.Jun 9 2020, 19:00

Closed by commit rABC910e12658934: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 9 2020, 19:36

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC910e12658934: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.

Revision Contents
Changeset List

Path

Size

src/

bench/

rollingbloom.cpp

8 lines

bloom.cpp

6 lines

Diff 21183

View Options

src/bench/rollingbloom.cpp