Page MenuHomePhabricator

txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN
ClosedPublic

Authored by deadalnix on Jun 10 2020, 14:49.

Details

Summary

This is a backport of Core PR16433

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.Jun 10 2020, 16:11
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/txmempool.h
373 ↗(On Diff #21223)

forgot to remove this

This revision now requires changes to proceed.Jun 10 2020, 16:11

Remove unknown enum element

Snippet of first build failure:

2020-06-10T17:42:01.300000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:42:01.301000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/wallet_txn_clone_181 on exit
2020-06-10T17:42:01.301000Z TestFramework (INFO): Test skipped
[17:42:48]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py --mineblock
[17:42:48]i:			 [wallet_txn_clone.py --mineblock] Test ignored: wallet_txn_clone.py --mineblock
[17:42:48]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-06-10T17:41:50.374000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-06-10T17:41:50.424000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:41:50.424000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/wallet_txn_clone_162 on exit
2020-06-10T17:41:50.424000Z TestFramework (INFO): Test skipped
[17:42:48]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py
[17:42:48]i:			 [wallet_txn_doublespend.py] Test ignored: wallet_txn_doublespend.py
[17:42:48]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-06-10T17:42:11.680000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-06-10T17:42:11.730000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:42:11.730000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/wallet_txn_doublespend_214 on exit
2020-06-10T17:42:11.730000Z TestFramework (INFO): Test skipped
[17:42:48]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py --mineblock
[17:42:48]i:			 [wallet_txn_doublespend.py --mineblock] Test ignored: wallet_txn_doublespend.py --mineblock
[17:42:48]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-06-10T17:41:50.498000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-06-10T17:41:50.549000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:41:50.549000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/wallet_txn_doublespend_163 on exit
2020-06-10T17:41:50.549000Z TestFramework (INFO): Test skipped
[17:42:48]i:		 [Bitcoin ABC functional tests] wallet_zapwallettxes.py
[17:42:48]i:			 [wallet_zapwallettxes.py] Test ignored: wallet_zapwallettxes.py
[17:42:48]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-06-10T17:41:48.622000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-06-10T17:41:48.672000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:41:48.672000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/wallet_zapwallettxes_151 on exit
2020-06-10T17:41:48.672000Z TestFramework (INFO): Test skipped
[17:42:48]i:		 [Bitcoin ABC functional tests] interface_zmq.py
[17:42:48]i:			 [interface_zmq.py] [Test Output]
2020-06-10T17:41:45.131000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/interface_zmq_148
2020-06-10T17:41:45.736000Z TestFramework (INFO): Generate 5 blocks (and 5 coinbase txes)
2020-06-10T17:42:46.817000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 183, in main
    self.run_test()
  File "/work/test/functional/interface_zmq.py", line 77, in run_test
    self._zmq_test()
  File "/work/test/functional/interface_zmq.py", line 93, in _zmq_test
    txid = self.hashtx.receive()
  File "/work/test/functional/interface_zmq.py", line 30, in receive
    topic, body, seq = self.socket.recv_multipart()
  File "/usr/lib/python3/dist-packages/zmq/sugar/socket.py", line 467, in recv_multipart
    parts = [self.recv(flags, copy=copy, track=track)]
  File "zmq/backend/cython/socket.pyx", line 788, in zmq.backend.cython.socket.Socket.recv
  File "zmq/backend/cython/socket.pyx", line 824, in zmq.backend.cython.socket.Socket.recv
  File "zmq/backend/cython/socket.pyx", line 191, in zmq.backend.cython.socket._recv_copy
  File "zmq/backend/cython/socket.pyx", line 186, in zmq.backend.cython.socket._recv_copy
  File "zmq/backend/cython/checkrc.pxd", line 19, in zmq.backend.cython.checkrc._check_rc
zmq.error.Again: Resource temporarily unavailable
2020-06-10T17:42:46.871000Z TestFramework (INFO): Stopping nodes
2020-06-10T17:42:46.980000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/interface_zmq_148
2020-06-10T17:42:46.980000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/test_runner_₿₵_  _20200610_174123/interface_zmq_148/test_framework.log
2020-06-10T17:42:46.980000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/test_runner_₿₵_  _20200610_174123/interface_zmq_148' to consolidate all logs
[17:42:50]E:	 [Step 1/2] Failed tests detected
[17:42:52]W:	 [Step 1/2] Process exited with code 1
[17:42:52]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: interface_zmq.py

This revision is now accepted and ready to land.Jun 11 2020, 23:56