Page MenuHomePhabricator
Differential D6508

Move CustomArgumentsFixture to an apropriate place
ClosedPublic
Actions

Authored by deadalnix on Jun 10 2020, 17:47.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCad72159d9dae: Move CustomArgumentsFixture to an apropriate place
Summary

As per title.

Test Plan
ninja all check-all
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 10 2020, 17:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2020, 17:47
deadalnix requested review of this revision.Jun 10 2020, 17:47
jasonbcox requested changes to this revision.Jun 10 2020, 18:03
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/util/args.cpp
5 ↗(On Diff #21240)

This probably doesn't belong in utils

This revision now requires changes to proceed.Jun 10 2020, 18:03
Harbormaster completed remote builds in B11396: Diff 21240.Jun 10 2020, 18:04
deadalnix updated this revision to Diff 22334.Jul 17 2020, 13:59

Do not move the fixture in the util lib, but still give it a proper name

Harbormaster completed remote builds in B12042: Diff 22334.Jul 17 2020, 14:13
jasonbcox accepted this revision.Jul 17 2020, 23:20
This revision is now accepted and ready to land.Jul 17 2020, 23:20
Closed by commit rABCad72159d9dae: Move CustomArgumentsFixture to an apropriate place (authored by deadalnix). · Explain WhyJul 18 2020, 12:43
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCad72159d9dae: Move CustomArgumentsFixture to an apropriate place.

Revision Contents
Changeset List

PathSize
src/
2 lines
test/
2 lines
fixture.cpp
main.cpp
4 lines

Diff 22354

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/fixture.cpp

Loading...
View Options

src/test/main.cpp

Loading...