[Qt] Fix deprecated pixmap() return by pointer with Qt 5.15
ClosedPublic
Actions

Authored by Fabien on Jun 15 2020, 13:29.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa7a19984d08a: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15

Summary

The pixmap() method returning a QImage * is deprecated with Qt 5.15.
It is replaced by a new pixmap(Qt::ReturnByValue) call which returns
by value as its name implies.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 15 2020, 13:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 13:29

Fabien requested review of this revision.Jun 15 2020, 13:29

I missed one

Add the missed one

Harbormaster completed remote builds in B11478: Diff 21379.Jun 15 2020, 13:59

deadalnix requested changes to this revision.Jun 15 2020, 14:08

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/guiutil.cpp
933 ↗	(On Diff #21384)	This API is pretty bad. Why not make it `hasPixmap` instead?
src/qt/receiverequestdialog.cpp
56 ↗	(On Diff #21384)	It looks like this could be factored.