Page MenuHomePhabricator
Differential D6596

[RPC docs] Remove unused index files
ClosedPublic
Actions

Authored by jasonbcox on Jun 15 2020, 21:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC148c4f7f071e: [RPC docs] Remove unused index files
Summary

These index files are not used and contain nothing useful. Now that D7130 and D7131 are landed, we know these index files will never be used.

Test Plan
ninja doc-rpc

Verify doc/rpc/en/0.22.0/index.html and doc/rpc/en/0.22.0/rpc/index.html are no longer generated.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 15 2020, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 21:42
jasonbcox requested review of this revision.Jun 15 2020, 21:42
Harbormaster completed remote builds in B11509: Diff 21438.Jun 15 2020, 22:03
deadalnix added a subscriber: deadalnix.Jun 15 2020, 22:57

It'd be probably preferable to use the template to generate something useful rather than removing this.

jasonbcox planned changes to this revision.Jun 15 2020, 23:04

It was conflicting with local tests of using nginx to generate a quick index for us prior to having a nicely-formatted index. But you're right, there's probably value in having this if we can fix it up.

Worst case and short term, we can remove the index files before we deploy so that a usable index is always present...

jasonbcox abandoned this revision.Aug 4 2020, 19:22
jasonbcox reclaimed this revision.Aug 10 2020, 22:07
jasonbcox updated this revision to Diff 22862.Aug 10 2020, 22:08

Rebase. See updated summary.

Harbormaster completed remote builds in B12368: Diff 22862.Aug 10 2020, 22:08
jasonbcox edited the summary of this revision. (Show Details)Aug 10 2020, 22:08
jasonbcox edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Aug 13 2020, 16:59
This revision is now accepted and ready to land.Aug 13 2020, 16:59
Closed by commit rABC148c4f7f071e: [RPC docs] Remove unused index files (authored by jasonbcox). · Explain WhyAug 13 2020, 22:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC148c4f7f071e: [RPC docs] Remove unused index files.

Revision Contents
Changeset List

PathSize
doc/
rpc/
29 lines

Diff 22888

View Options

doc/rpc/generate.go

Loading...