Page MenuHomePhabricator

[backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions
ClosedPublic

Authored by majcosta on Jun 18 2020, 23:53.

Details

Summary

c87fc71f7e Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr)
097c4aa379 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr)

Pull request description:

When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise.
Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used.
The error code is still checked to ensure it is of the correct kind of failure.

Backport of Core PR14818

Test Plan
ninja
test_runner rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 18 2020, 23:59
deadalnix requested changes to this revision.Jun 18 2020, 23:59
deadalnix added inline comments.
test/functional/rpc_psbt.py
136 ↗(On Diff #21556)

Fix the comment to dewitnessify it.

This revision now requires changes to proceed.Jun 18 2020, 23:59
deadalnix requested changes to this revision.Jun 20 2020, 01:41
deadalnix added inline comments.
test/functional/rpc_psbt.py
134 ↗(On Diff #21557)

scriptWitnesses

This revision now requires changes to proceed.Jun 20 2020, 01:41
This revision is now accepted and ready to land.Jun 21 2020, 20:25