Page MenuHomePhabricator
Differential D6660

[backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables
ClosedPublic
Actions

Authored by majcosta on Jun 22 2020, 04:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc7bc25d97f07: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and…
Summary

The new descriptors argument needs to be added to the Command and
ConvertParams tables to by usable as a named argument and by
bitcoin-cli.

Also update the test to use named arguments to test this.

Backport of Core PR16326

Test Plan
ninja
test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 22 2020, 04:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2020, 04:52
majcosta requested review of this revision.Jun 22 2020, 04:52
teamcity edited the summary of this revision. (Show Details)Jun 22 2020, 04:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11598: Diff 21583.Jun 22 2020, 05:07
Fabien requested changes to this revision.Jun 22 2020, 07:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
13 ↗(On Diff #21583)

Remove segwit references

This revision now requires changes to proceed.Jun 22 2020, 07:35
majcosta updated this revision to Diff 21589.Jun 22 2020, 08:27

removed segwit references

Fabien accepted this revision.Jun 22 2020, 08:36
This revision is now accepted and ready to land.Jun 22 2020, 08:36
Harbormaster completed remote builds in B11604: Diff 21589.Jun 22 2020, 08:38
Closed by commit rABCc7bc25d97f07: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and… (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJun 23 2020, 18:43
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc7bc25d97f07: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and….

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
1 line
2 lines
test/
functional/
2 lines

Diff 21662

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...