Page MenuHomePhabricator

[backport#16512] rpc: Shuffle inputs and outputs after joining psbts
ClosedPublic

Authored by majcosta on Jun 22 2020, 08:28.

Details

Summary

Pull request description:

`joinpsbts` currently just adds the inputs and outputs in the order of that the PSBTs were provided. This makes it extremely easy to identify which outputs belong to which inputs. This PR changes that so that all of the inputs and outputs are shuffled in the joined transaction.

Backport of Core PR16512

Test Plan
ninja
./test/functional/test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_psbt.py
327 ↗(On Diff #21590)

This is a call for flaky test... Let's see how it goes

This revision is now accepted and ready to land.Jun 22 2020, 20:50