Page MenuHomePhabricator
Differential D6665

[backport#16512] rpc: Shuffle inputs and outputs after joining psbts
ClosedPublic
Actions

Authored by majcosta on Jun 22 2020, 08:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbb01006c69ee: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts
Summary

Pull request description:

`joinpsbts` currently just adds the inputs and outputs in the order of that the PSBTs were provided. This makes it extremely easy to identify which outputs belong to which inputs. This PR changes that so that all of the inputs and outputs are shuffled in the joined transaction.

Backport of Core PR16512

Test Plan
ninja
./test/functional/test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 22 2020, 08:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2020, 08:28
majcosta requested review of this revision.Jun 22 2020, 08:28
teamcity edited the summary of this revision. (Show Details)Jun 22 2020, 08:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11605: Diff 21590.Jun 22 2020, 08:43
Fabien accepted this revision.Jun 22 2020, 20:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_psbt.py
327 ↗(On Diff #21590)

This is a call for flaky test... Let's see how it goes

This revision is now accepted and ready to land.Jun 22 2020, 20:50
Closed by commit rABCbb01006c69ee: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyJun 23 2020, 18:30
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCbb01006c69ee: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.

Revision Contents
Changeset List

PathSize
doc/
6 lines
src/
rpc/
29 lines
test/
functional/
10 lines

Diff 21658

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...