Page MenuHomePhabricator

Do not review
AbandonedPublic

Authored by Fabien on Tue, Jun 23, 07:32.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This diff demonstrates the clang tidy behavior in case of a brace
missing, see D6627.

Depends on D6627.

Test Plan

Do not review

Event Timeline

Fabien created this revision.Tue, Jun 23, 07:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 23, 07:32
Fabien requested review of this revision.Tue, Jun 23, 07:32
Fabien planned changes to this revision.Tue, Jun 23, 07:32
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien updated this revision to Diff 21620.Tue, Jun 23, 08:52

Rebase due to D6676

Fabien planned changes to this revision.Tue, Jun 23, 08:53

Snippet of first build failure:

[09:08:31] :	 [Step 1/1] [417/459] Linking CXX executable src/bench/bitcoin-bench
[09:08:31] :	 [Step 1/1] [418/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsdialog.cpp.o
[09:08:31] :	 [Step 1/1] [419/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/guiutil.cpp.o
[09:08:32] :	 [Step 1/1] [420/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o
[09:08:32] :	 [Step 1/1] [421/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/peertablemodel.cpp.o
[09:08:32] :	 [Step 1/1] [422/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/trafficgraphwidget.cpp.o
[09:08:33] :	 [Step 1/1] [423/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroltreewidget.cpp.o
[09:08:33] :	 [Step 1/1] [424/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addressbookpage.cpp.o
[09:08:34] :	 [Step 1/1] [425/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/editaddressdialog.cpp.o
[09:08:34] :	 [Step 1/1] [426/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o
[09:08:35] :	 [Step 1/1] [427/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/askpassphrasedialog.cpp.o
[09:08:35] :	 [Step 1/1] [428/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o
[09:08:37] :	 [Step 1/1] [429/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/openuridialog.cpp.o
[09:08:38] :	 [Step 1/1] [430/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/overviewpage.cpp.o
[09:08:38] :	 [Step 1/1] [431/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[09:08:38] :	 [Step 1/1] [432/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addresstablemodel.cpp.o
[09:08:39] :	 [Step 1/1] [433/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/recentrequeststablemodel.cpp.o
[09:08:39] :	 [Step 1/1] [434/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondescdialog.cpp.o
[09:08:40] :	 [Step 1/1] [435/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionfilterproxy.cpp.o
[09:08:40] :	 [Step 1/1] [436/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o
[09:08:40] :	 [Step 1/1] [437/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsentry.cpp.o
[09:08:41] :	 [Step 1/1] [438/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receivecoinsdialog.cpp.o
[09:08:41] :	 [Step 1/1] [439/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroldialog.cpp.o
[09:08:41] :	 [Step 1/1] [440/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[09:08:42] :	 [Step 1/1] [441/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentserver.cpp.o
[09:08:43] :	 [Step 1/1] [442/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionrecord.cpp.o
[09:08:44] :	 [Step 1/1] [443/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondesc.cpp.o
[09:08:44] :	 [Step 1/1] [444/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletframe.cpp.o
[09:08:44] :	 [Step 1/1] [445/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsdialog.cpp.o
[09:08:44] :	 [Step 1/1] [446/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/signverifymessagedialog.cpp.o
[09:08:45] :	 [Step 1/1] [447/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodeltransaction.cpp.o
[09:08:45] :	 [Step 1/1] [448/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentrequestplus.cpp.o
[09:08:45] :	 [Step 1/1] [449/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionview.cpp.o
[09:08:45] :	 [Step 1/1] [450/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletcontroller.cpp.o
[09:08:45] :	 [Step 1/1] [451/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiontablemodel.cpp.o
[09:08:46] :	 [Step 1/1] [452/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletview.cpp.o
[09:08:47] :	 [Step 1/1] [453/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin-qt-base_autogen/mocs_compilation.cpp.o
[09:08:47] :	 [Step 1/1] [454/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodel.cpp.o
[09:08:49] :	 [Step 1/1] [455/459] Linking CXX static library src/qt/libbitcoin-qt-base.a
[09:08:49] :	 [Step 1/1] [456/459] Automatic MOC for target bitcoin-qt
[09:08:49] :	 [Step 1/1] [457/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[09:08:49] :	 [Step 1/1] [458/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[09:08:50] :	 [Step 1/1] [459/459] Linking CXX executable src/qt/bitcoin-qt
[09:08:50] :	 [Step 1/1] /work /work/build-clang-tidy
[09:08:50]W:	 [Step 1/1] + : clang-tidy-diff-8.py
[09:08:50]W:	 [Step 1/1] + CLANG_TIDY_WARNING_FILE=/work/build-clang-tidy/clang-tidy-warnings.txt
[09:08:50]W:	 [Step 1/1] + pushd /work
[09:08:50]W:	 [Step 1/1] + git diff -U0 'HEAD^'
[09:08:50]W:	 [Step 1/1] + clang-tidy-diff-8.py -path /work/build-clang-tidy/compile_commands.json -p1
[09:08:50]W:	 [Step 1/1] /bin/sh: 1: clang-tidy: not found
[09:08:50] :	 [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[09:08:50]W:	 [Step 1/1] ++ print_sanitizers_log
[09:08:50]W:	 [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[09:08:50]W:	 [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[09:08:50]W:	 [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[09:08:50]W:	 [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[09:08:50]W:	 [Step 1/1] cp: cannot stat '/work/build': No such file or directory
[09:08:50]W:	 [Step 1/1] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[09:09:00]W:	 [Step 1/1] Process exited with code 1
[09:09:00]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Fabien updated this revision to Diff 21623.Tue, Jun 23, 09:19

Rebase

Snippet of first build failure:

[09:31:21] :	 [Step 1/1] [424/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addressbookpage.cpp.o
[09:31:22] :	 [Step 1/1] [425/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/editaddressdialog.cpp.o
[09:31:23] :	 [Step 1/1] [426/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o
[09:31:23] :	 [Step 1/1] [427/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o
[09:31:23] :	 [Step 1/1] [428/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/askpassphrasedialog.cpp.o
[09:31:24] :	 [Step 1/1] [429/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/openuridialog.cpp.o
[09:31:26] :	 [Step 1/1] [430/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addresstablemodel.cpp.o
[09:31:26] :	 [Step 1/1] [431/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/overviewpage.cpp.o
[09:31:26] :	 [Step 1/1] [432/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[09:31:26] :	 [Step 1/1] [433/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondescdialog.cpp.o
[09:31:27] :	 [Step 1/1] [434/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o
[09:31:27] :	 [Step 1/1] [435/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/recentrequeststablemodel.cpp.o
[09:31:28] :	 [Step 1/1] [436/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionfilterproxy.cpp.o
[09:31:29] :	 [Step 1/1] [437/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsentry.cpp.o
[09:31:29] :	 [Step 1/1] [438/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroldialog.cpp.o
[09:31:29] :	 [Step 1/1] [439/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receivecoinsdialog.cpp.o
[09:31:29] :	 [Step 1/1] [440/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[09:31:29] :	 [Step 1/1] [441/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentserver.cpp.o
[09:31:31] :	 [Step 1/1] [442/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondesc.cpp.o
[09:31:31] :	 [Step 1/1] [443/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/signverifymessagedialog.cpp.o
[09:31:31] :	 [Step 1/1] [444/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionrecord.cpp.o
[09:31:32] :	 [Step 1/1] [445/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionview.cpp.o
[09:31:32] :	 [Step 1/1] [446/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletframe.cpp.o
[09:31:32] :	 [Step 1/1] [447/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsdialog.cpp.o
[09:31:32] :	 [Step 1/1] [448/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiontablemodel.cpp.o
[09:31:32] :	 [Step 1/1] [449/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletcontroller.cpp.o
[09:31:32] :	 [Step 1/1] [450/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodeltransaction.cpp.o
[09:31:33] :	 [Step 1/1] [451/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentrequestplus.cpp.o
[09:31:34] :	 [Step 1/1] [452/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletview.cpp.o
[09:31:34] :	 [Step 1/1] [453/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin-qt-base_autogen/mocs_compilation.cpp.o
[09:31:35] :	 [Step 1/1] [454/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodel.cpp.o
[09:31:35] :	 [Step 1/1] [455/459] Linking CXX static library src/qt/libbitcoin-qt-base.a
[09:31:35] :	 [Step 1/1] [456/459] Automatic MOC for target bitcoin-qt
[09:31:35] :	 [Step 1/1] [457/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[09:31:36] :	 [Step 1/1] [458/459] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[09:31:37] :	 [Step 1/1] [459/459] Linking CXX executable src/qt/bitcoin-qt
[09:31:37]W:	 [Step 1/1] + : clang-tidy-diff-8.py
[09:31:37]W:	 [Step 1/1] + CLANG_TIDY_WARNING_FILE=/work/build-clang-tidy/clang-tidy-warnings.txt
[09:31:37]W:	 [Step 1/1] + pushd /work
[09:31:37] :	 [Step 1/1] /work /work/build-clang-tidy
[09:31:37]W:	 [Step 1/1] + git diff -U0 'HEAD^'
[09:31:37]W:	 [Step 1/1] ++ command -v clang-tidy-8
[09:31:37]W:	 [Step 1/1] + clang-tidy-diff-8.py -clang-tidy-binary /usr/bin/clang-tidy-8 -path /work/build-clang-tidy/compile_commands.json -p1
[09:31:38]W:	 [Step 1/1] 1869 warnings generated.
[09:31:38]W:	 [Step 1/1] Suppressed 1866 warnings (1866 in non-user code).
[09:31:38]W:	 [Step 1/1] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[09:31:38]W:	 [Step 1/1] ++ wc -l
[09:31:38]W:	 [Step 1/1] + '[' 4 -gt 1 ']'
[09:31:38]W:	 [Step 1/1] + echo 'clang-tidy found issues !'
[09:31:38]W:	 [Step 1/1] + cat /work/build-clang-tidy/clang-tidy-warnings.txt
[09:31:38]W:	 [Step 1/1] + exit 1
[09:31:38] :	 [Step 1/1] clang-tidy found issues !
[09:31:38] :	 [Step 1/1] /work/src/addrdb.cpp:48:26: warning: statement should be inside braces [readability-braces-around-statements]
[09:31:38] :	 [Step 1/1]     if (fileout.IsNull())
[09:31:38] :	 [Step 1/1]                          ^
[09:31:38] :	 [Step 1/1]                           {
[09:31:38]W:	 [Step 1/1] cp: cannot stat '/work/build': No such file or directory
[09:31:38]W:	 [Step 1/1] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[09:31:45]W:	 [Step 1/1] Process exited with code 1
[09:31:45]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Fabien planned changes to this revision.Tue, Jun 23, 09:32
Fabien abandoned this revision.Tue, Jun 23, 19:55