Page MenuHomePhabricator

[CI] Don't print an error if there is no sanitizer log files
ClosedPublic

Authored by Fabien on Tue, Jun 23, 13:42.

Details

Summary

This prints a confusing error message when there is no sanitizer log
(e.g. in case the failure is not due to the sanitizer). This diff fixes
the issue by testing for the existance of the file prior to printing it.

Test Plan

$
Edit the build configuration so that the print_sanitizers_log traps the
EXIT instead of ERR. Run any CI build plan and check that the following
error message is no longer displayed:

cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jun 23, 13:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 23, 13:42
Fabien requested review of this revision.Tue, Jun 23, 13:42
deadalnix accepted this revision.Tue, Jun 23, 14:08
This revision is now accepted and ready to land.Tue, Jun 23, 14:08