Page MenuHomePhabricator
Differential D6709

Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime
ClosedPublic
Actions

Authored by jasonbcox on Jun 24 2020, 18:04.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC7cb92239e4ad: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at…
Summary

bbbbb3f8850907d413db4715c10ef6df055234f6 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke)

Pull request description:

This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime)

Tree-SHA512: 0226e7c65f8a1a6fdc96c07dcf491d90559bc2355c92e9da9b1f174b09733fc349269e71da6d792f954de563a1e57c848471813eabae1a40b849a0d989520a0d

Backport of Core PR14658

Test Plan

test_runner.py rpc_help

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox requested review of this revision.Jun 24 2020, 18:04
jasonbcox planned changes to this revision.
jasonbcox created this revision.
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 18:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox edited the summary of this revision. (Show Details)Jun 24 2020, 18:05
jasonbcox edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B11668: Diff 21705.Jun 24 2020, 18:21
jasonbcox requested review of this revision.Jun 24 2020, 18:27
majcosta accepted this revision.Jun 24 2020, 19:00
This revision is now accepted and ready to land.Jun 24 2020, 19:00
Closed by commit rABC7cb92239e4ad: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJun 24 2020, 20:21
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC7cb92239e4ad: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at….

Revision Contents
Changeset List

PathSize
test/
functional/
17 lines

Diff 21722

View Options

test/functional/rpc_help.py

Loading...