Page MenuHomePhabricator
Differential D6774

Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
ClosedPublic
Actions

Authored by jasonbcox on Jun 29 2020, 20:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCeb48537aa444: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
Summary

1cdb9bb51f minor p2p_sendheaders fix of height in coinbase (Gregory Sanders)

Pull request description:

> \# Now announce a header that forks the last two blocks

Doesn't effect any behavior since BIP34 isn't active in regtest for many blocks.

Tree-SHA512: 3f214b956a94250bb640f63b6ff707930e1d4cb8df1bbf0fef4012d89a94bafbde0d7b42bbe7113ec33810169281c22c6e389445921d99decb74aa56e87a0f27

Backport of Core PR14543

Test Plan

test_runner.py p2p_sendheaders

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 29 2020, 20:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 20:44
jasonbcox requested review of this revision.Jun 29 2020, 20:44
teamcity edited the summary of this revision. (Show Details)Jun 29 2020, 20:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Jun 29 2020, 20:49
This revision is now accepted and ready to land.Jun 29 2020, 20:49
Harbormaster completed remote builds in B11776: Diff 21867.Jun 29 2020, 20:59
Closed by commit rABCeb48537aa444: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 29 2020, 21:42
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCeb48537aa444: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 21873

View Options

test/functional/p2p_sendheaders.py

Loading...