Differential D6795

[backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
ClosedPublic
Actions

Authored by majcosta on Jun 30 2020, 23:13.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC8790173c76a4: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency

Summary

This ensures wallet code doesn't access node global state, avoiding bugs like
https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431

https://github.com/bitcoin/bitcoin/pull/15639/commits/78a2fb55c97fbc26f7b74c5b1fb999a2aff8ce88

Test Plan

ninja check-all [also with -DBUILD_BITCOIN_WALLET=OFF]

make check-recursive 
./test/functional/test_runner.py [also with --disable-wallet]

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 30 2020, 23:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2020, 23:13

majcosta requested review of this revision.Jun 30 2020, 23:13

Harbormaster completed remote builds in B11803: Diff 21913.Jun 30 2020, 23:28

deadalnix requested changes to this revision.Jun 30 2020, 23:37

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/wallet/CMakeLists.txt
32 ↗	(On Diff #21913)	I'm pretty sure bitcoinconsensus is wrong here.

This revision now requires changes to proceed.Jun 30 2020, 23:37

Discussed off line. This is good.

This revision is now accepted and ready to land.Jun 30 2020, 23:54

Closed by commit rABC8790173c76a4: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyJul 1 2020, 00:01

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC8790173c76a4: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.

Revision Contents
Changeset List

Path

Size

src/

Makefile.am

1 line

wallet/

CMakeLists.txt

2 lines

Diff 21918

View Options

src/Makefile.am