Page MenuHomePhabricator
Differential D6804

[backport#16415] Get rid of PendingWalletTx class.
ClosedPublic
Actions

Authored by majcosta on Jul 1 2020, 21:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd3670a9f5b31: [backport#16415] Get rid of PendingWalletTx class.
Summary

No reason for this class to exist if it doesn't have any code to run in the
destructor. e10e1e8db043e9b7c113e07faf408f337c1b732d from
https://github.com/bitcoin/bitcoin/pull/16208 recently removed code destructor
code that would return an unused key if the transaction wasn't committed.

https://github.com/bitcoin/bitcoin/pull/16415/commits/4d94916f0dda535cb69b538ee4e3fffb5b033c87

Backport of Core PR16415

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 1 2020, 21:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2020, 21:24
majcosta requested review of this revision.Jul 1 2020, 21:24
teamcity edited the summary of this revision. (Show Details)Jul 1 2020, 21:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11816: Diff 21948.Jul 1 2020, 21:36
Fabien accepted this revision.Jul 2 2020, 08:48
This revision is now accepted and ready to land.Jul 2 2020, 08:48
Closed by commit rABCd3670a9f5b31: [backport#16415] Get rid of PendingWalletTx class. (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyJul 2 2020, 14:22
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd3670a9f5b31: [backport#16415] Get rid of PendingWalletTx class..

Revision Contents
Changeset List

PathSize
src/
interfaces/
22 lines
49 lines
qt/
2 lines
6 lines
5 lines
6 lines

Diff 21957

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/qt/walletmodeltransaction.h

Loading...
View Options

src/qt/walletmodeltransaction.cpp

Loading...